Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Alps, remove Todi #233

Merged
merged 18 commits into from
Dec 18, 2024
Merged

Update Alps, remove Todi #233

merged 18 commits into from
Dec 18, 2024

Conversation

mjaehn
Copy link
Contributor

@mjaehn mjaehn commented Dec 17, 2024

No description provided.

@mjaehn mjaehn requested review from leclairm and AnnikaLau December 17, 2024 13:47
AnnikaLau
AnnikaLau requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@AnnikaLau AnnikaLau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions, as I found some of the sentences a too long or not totally clear. Furthermore, we should also update the install instructions of ICON within this MR.

docs/alps/vclusters.md Outdated Show resolved Hide resolved
docs/alps/vclusters.md Outdated Show resolved Hide resolved
docs/alps/vclusters.md Outdated Show resolved Hide resolved
docs/alps/vclusters.md Outdated Show resolved Hide resolved
docs/alps/vclusters.md Outdated Show resolved Hide resolved
docs/alps/vclusters.md Outdated Show resolved Hide resolved
docs/posts/2024-12-17_alps_update.md Outdated Show resolved Hide resolved
mjaehn and others added 14 commits December 17, 2024 15:31
@mjaehn @AnnikaLau
Update docs/alps/vclusters.md
d1b8885 
Co-authored-by: Annika Lauber <[email protected]>
@mjaehn @AnnikaLau
Update docs/alps/vclusters.md
bb4eb06 
Co-authored-by: Annika Lauber <[email protected]>
@mjaehn @AnnikaLau
Update docs/alps/vclusters.md
a63b11b 
Co-authored-by: Annika Lauber <[email protected]>
@mjaehn @AnnikaLau
Update docs/alps/vclusters.md
6580ad6 
Co-authored-by: Annika Lauber <[email protected]>
@mjaehn @AnnikaLau
Update docs/posts/2024-12-17_alps_update.md
ca5836d 
Co-authored-by: Annika Lauber <[email protected]>
@mjaehn @AnnikaLau
Update docs/alps/vclusters.md
a7472fd 
Co-authored-by: Annika Lauber <[email protected]>
@mjaehn
Update vclusters
e8c87c2
@mjaehn
Unify vCluster names
b75a152
@AnnikaLau
Remove Tödi from install instructions
36188fc
@mjaehn
Use todi for spack sysconfig
a6b029d
@mjaehn
Rename todi to alps
26f1377
@AnnikaLau
Add instructions to create missing folders
593348e
@AnnikaLau
Swap santis with daint
882e487
@mjaehn
mkdir -p
1d3b892
@mjaehn mjaehn requested a review from AnnikaLau December 18, 2024 11:01
@mjaehn mjaehn enabled auto-merge (squash) December 18, 2024 11:03
AnnikaLau
AnnikaLau approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@AnnikaLau AnnikaLau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toll gemacht!

@mjaehn mjaehn merged commit ef4360a into main Dec 18, 2024
3 checks passed
@mjaehn mjaehn deleted the todi2santis branch December 18, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnikaLau AnnikaLau AnnikaLau approved these changes

@leclairm leclairm Awaiting requested review from leclairm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjaehn @AnnikaLau