Add visualization graph #39
Conversation
Generate an svg graph from the core IR using pygraphviz and adding some interactivity with javascript
It doesn't contain any piece of logic or code we now have in core.py or vizgraph.py
There was a problem hiding this comment.
Since I take it that this is heavily based on https://github.com/BartBrood/Interactive-Graphviz-Diagrams, it would be fair to honor it's MIT license: https://github.com/BartBrood/Interactive-Graphviz-Diagrams/blob/main/LICENSE and include the copyright at the beginning of this file (and probably the CSS file as well?).
Might also be not too early now to think about what license the rest of this code should have.
There was a problem hiding this comment.
It's not heavily based it's 99% copied! I didn't see there was a license. Yes I should absolutely include that.
There was a problem hiding this comment.
Oh it's actually brand new. When I "stole" it, it was only one file in the repo. There might be even more to borrow and acknowledge, then.
There was a problem hiding this comment.
Might also be not too early now to think about what license the rest of this code should have.
True, I'm happy to receive any input for that, I'm not really used to it.
There was a problem hiding this comment.
I created issue #41 to add a license for the project.
True, I always only look at the large one. It shows the visualization is good check to have! We probably need a PR to well define which scenarios we want to test. |
Co-authored-by: Rico Haeuselmann <[email protected]>
This makes me realize we don't have a way to express that ICON can use some initial condition data only for the first cycle. It's the same issue as ignoring input data that falls outside of the target data date range: we're missing a way to express when the input data specification should be taken into account. This is now the topic of issue #40 |
Generate an svg graph from the core IR using pygraphviz and adding some interactivity with javascript
NOTE: This requires graphviz to be installed locally