Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Julian Geiger <[email protected]>
  • Loading branch information
agoscinski and GeigerJ2 authored Sep 12, 2024
1 parent b1c0d72 commit ce5144b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/wcflow/wc/_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ def _to_core_cycle(self, cycle: Cycle) -> core.Cycle:
def _to_core_task(self, task: CycleTask) -> core.Task:
inputs = []
outputs = []
dependcies = []
dependencies = []
for input_ in task.inputs:
if (data := self._data.get(input_.name)) is None:
msg = f"Task {task.name!r} has input {input_.name!r} that is not specied in the data section."
Expand All @@ -381,7 +381,7 @@ def _to_core_task(self, task: CycleTask) -> core.Task:
outputs.append(core_data)
for depend in task.depends:
core_dependency = core.Dependency(depend.task_name, depend.lag, depend.date, depend.cycle_name)
dependcies.append(core_dependency)
dependencies.append(core_dependency)

return core.Task(
task.name,
Expand Down
2 changes: 1 addition & 1 deletion src/wcflow/workgraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def _validate_workflow(self):
except ValueError as exception:
msg = f"Raised error when validating input name '{input_.name}': {exception.args[0]}"
raise ValueError(msg) from exception
for output in task.unrolled_inputs:
for output in task.unrolled_outputs:
try:
aiida.common.validate_link_label(task.name)
except ValueError as exception:
Expand Down

0 comments on commit ce5144b

Please sign in to comment.