Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic UX / UI improvements #205

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

basic UX / UI improvements #205

wants to merge 13 commits into from

Conversation

Chinyeins
Copy link

@Chinyeins Chinyeins commented Nov 9, 2023

Basic UX and UI Improvements and proposals for this great project:

Heres the list of improvements I propose:

  1. Make Settings more accessible and easy to read
  2. Hide API KEY by deafault
  3. Add volume slider to manage TTS Volume

Already impl. with this

  • Improved Settings Page layout and behaviour
  • added auto hide API-KEY for ElevenLabs, since the value is a secret it should be hidden always, unless user wants to see value explicitly
  • refactored settings page, visually improved settings page and made options readable
  • added settings page close on press escape button, for convenience
  • introduced volume slider to handle tts volume, since default volume of 1 can be pretty loud. Vol is saved in chrome localStorage and rea applied to slider on startup page.

@Chinyeins Chinyeins marked this pull request as draft November 15, 2023 17:08
@Chinyeins Chinyeins changed the title Slight Improvements Improvements Nov 15, 2023
@Chinyeins Chinyeins changed the title Improvements basic UX / UI improvements Nov 15, 2023
@zedatrix
Copy link

Is this planned to be added?

@Chinyeins
Copy link
Author

Is this planned to be added?

i will implement all the things that bother me and are defined on that list. If they will be added to the OG repository, we need to see what @C-Nedelcu will say about the PR when its done. Currently it´s work in progress. ^^

Repository owner deleted a comment from dev-eduka Nov 25, 2023
@C-Nedelcu
Copy link
Owner

yes I am waiting for this to be completed - thanks and keep up the good work !

@C-Nedelcu
Copy link
Owner

also please note that there is another pending pull request (already complete) that adds Azure TTS. You may need to make some changes before merging.

I'm not ready yet with the Azure TTS but once I do it'll be a new sub-version i.e. v2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants