Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hor autoscale docs #298

Merged
merged 36 commits into from
Jan 10, 2025

Conversation

martijneichelsheim
Copy link
Contributor

@martijneichelsheim martijneichelsheim commented Dec 17, 2024

Horizontal autoscaling Info and Enabling in CP documentation

Copy link

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

github-actions bot commented Jan 3, 2025

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

github-actions bot commented Jan 3, 2025

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

github-actions bot commented Jan 6, 2025

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

Copy link

github-actions bot commented Jan 6, 2025

Detected renamed/moved files:

docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md => docs/hypernode-platform/autoscaling/how-does-vertical-autoscaling-work.md
docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md => docs/hypernode-platform/autoscaling/how-to-enable-vertical-autoscaling.md

To prevent 404 pages, consider adding the redirects to the new pages:

---
redirect_from:
  - docs/hypernode-platform/autoscaling/how-does-autoscaling-work.md
  - docs/hypernode-platform/autoscaling/how-to-enable-autoscaling.md
---

1 similar comment
php bin/magento config:set system/full_page_cache/varnish/backend_host varnish
```

Additionally make sure the IP range `10.0.0.0/24` is set to the `acl_purge` section in the Varnish VCL file. The `acl_purge` section should look something similar:loaded Varnish VCL.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we say the location of the file here?

etc/varnish/default.vcl etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't really know where the VCL file is, that's up to the user - they should know where it's located. Once you load a VCL into varnish, varnish doesn't know where the VCL came from. We do backup the VCL to /data/var/varnish/default.vcl so it loads in the same VCL when you restart varnish.

app@abcdef-example-magweb-cmbl:~$ ll /data/var/varnish/default.vcl
-rw-r--r-- 1 root root 8.3K Jan 10 11:50 /data/var/varnish/default.vcl
app@abcdef-example-magweb-cmbl:~$ ll /etc/varnish/default.vcl
lrwxrwxrwx 1 root root 29 Jan  7 07:25 /etc/varnish/default.vcl -> /data/var/varnish/default.vcl


Additionally make sure the IP range `10.0.0.0/24` is set to the `acl_purge` section in the Varnish VCL file. The `acl_purge` section should look something similar:loaded Varnish VCL.

```console

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to include the following in vcl_recv for handling PURGE requests?

sub vcl_recv {
if (req.method == "PURGE") {
if (!client.ip ~ purge) {
return (synth(405, "Not allowed."));
}
return (purge);
}
}

Curious if this is required ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that's completely up to the users

@hrithikkothari1234 hrithikkothari1234 merged commit f7fc97d into master Jan 10, 2025
9 checks passed
@hrithikkothari1234 hrithikkothari1234 deleted the documentation-horizontal-autoscaling branch January 10, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants