Skip to content

Commit

Permalink
Fixed more visibility problems of FilterPreset controls
Browse files Browse the repository at this point in the history
  • Loading branch information
Burtan committed Mar 28, 2020
1 parent f1d28c7 commit ba27fe4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 12 deletions.
4 changes: 0 additions & 4 deletions src/main/cpp/controller/LivePresetEditController.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ void LivePresetEditController::onInitDlg() {
defWndProc = (WNDPROC) SetWindowLongPtr(mHwnd, GWLP_WNDPROC, (LONG_PTR) wndProc);
}

ShowWindow(GetDlgItem(mHwnd, IDC_LABEL1), SW_HIDE);
ShowWindow(GetDlgItem(mHwnd, IDC_COMBO), SW_HIDE);
ShowWindow(GetDlgItem(mHwnd, IDC_SETTINGS), SW_HIDE);

//create combobox
mCombo = std::make_unique<ComboBox>(GetDlgItem(mHwnd, IDC_COMBO));
auto comboAdapter = std::make_unique<FilterPresetsComboAdapter>(FilterPreset_GetNames(g_lpe->mModel.mFilterPresets));
Expand Down
2 changes: 1 addition & 1 deletion src/main/cpp/controller/LivePresetsController.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ void LivePresetsController::onContextMenu(HMENU menu) {
auto indices = mList->getSelectedIndices();
auto filters = FilterPreset_GetNames(g_lpe->mModel.mFilterPresets);

if (Licensing_IsUltimate() && !indices.empty()) {
if (!indices.empty()) {

//show list of filter presets
HMENU subMenu = CreatePopupMenu();
Expand Down
3 changes: 0 additions & 3 deletions src/main/cpp/controller/SettingsController.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ void SettingsController::onInitDlg() {
CheckDlgButton(mHwnd, IDC_RECALL_ACTIVE_PRESETS, g_lpe->mModel.mIsReselectLivePresetByValueRecall);
CheckDlgButton(mHwnd, IDC_HIDE_MUTED_TRACKS, g_lpe->mModel.mIsHideMutedTracks);

ShowWindow(GetDlgItem(mHwnd, IDC_LABEL1), SW_HIDE);
ShowWindow(GetDlgItem(mHwnd, IDC_COMBO), SW_HIDE);

//create combo add FilterPreset names and select default
mCombo = std::make_unique<ComboBox>(GetDlgItem(mHwnd, IDC_COMBO));
std::vector<std::string*> filterNames = FilterPreset_GetNames(g_lpe->mModel.mFilterPresets);
Expand Down
8 changes: 4 additions & 4 deletions src/main/headers/resources/resource.rc
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ STYLE DS_SETFONT | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU | WS_THICKFR
FONT 8, "MS Shell Dlg"
BEGIN
PUSHBUTTON "Add Hardware",IDC_ADD,8,8,72,16
PUSHBUTTON "Remove Hardware",IDC_REMOVE,88,8,72,16
PUSHBUTTON "Add Control",IDC_ADD2,456,8,72,16
PUSHBUTTON "Remove Control",IDC_REMOVE2,536,8,72,16
CONTROL "TabControl", IDC_TAB,"SysTabControl32",WS_TABSTOP,8,72,600,300
PUSHBUTTON "Remove Hardware",IDC_REMOVE,88,8,72,16
PUSHBUTTON "Add Control",IDC_ADD2,456,8,72,16
PUSHBUTTON "Remove Control",IDC_REMOVE2,536,8,72,16
CONTROL "TabControl", IDC_TAB,"SysTabControl32",WS_TABSTOP,8,72,600,300
END

IDD_ABOUT DIALOGEX 0, 0, 600, 300
Expand Down

0 comments on commit ba27fe4

Please sign in to comment.