Use proc_ops structure for kernel version >= 5.6.0 #196
Conversation
|
Yes please, this totally breaks on 5.6 otherwhise. Not sure if this is still even in development tho @Lekensteyn |
|
Please merge ASAP. I know this repo is basically unmaintained but this is important |
|
Welp, was going to open the same pull request. Can confirm it seems to work @Lekensteyn Not wanting to be rude, but this is urgent for rolling release users |
|
Ok guys, It seems this repo is unmaintained. Is it time to fork it? |
Please be patient. 5.6 is scarcely used. Rolling distros can have a patch for now. |
|
I can look into this later. It would help if you could track down the upstream commit and mention it in the commit message. That should make it clear whether this approach is the right one or not. |
mateuszmandera
force-pushed
the
kernel_560
branch
from
0b11f33
to
4dbde53
Compare
|
@Lekensteyn torvalds/linux@d56c0d4 (added to my commit message as well) |
The change is very small though, and people have reported that it works. 5.7 will be released somewhere after next week. Fedora is already on 5.6. Also, it might very well be that bbswitch is most popular among technically-inclined users, like those on rolling distros. More generally, I don't think that Arch and Manjaro are that scarcely used. (manjaro is ranked second on distrowatch, if that says anything) |
Since 5.6.0, proc_create requires a `struct proc_ops *` argument instead of `struct file_operations *`. Commit with the migration in the kernel source can be found at torvalds/linux@d56c0d4
|
Thanks for the fix and sorry for the delay. I made some whitespace changes, removed the unnecessary |
Since 5.6.0, proc_create requires a proc_ops* argument
instead of file_operations*.
It compiles and seems to work on my machine, but I haven't done much testing. Please review if this is the correct way to migrate to the new structure.