Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added a note to component's children section #1600

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

seasheepjoe
Copy link
Contributor

@seasheepjoe seasheepjoe commented Oct 21, 2024

Description

Please provide the following information:

  • What changes you made:

Added a note to the component page in the docs on the children section.

  • Why you made them, and:
    Clarification of the docs and wanting to inform users that the children prop is not iterable.

  • Any other useful context:
    This PR is a necessary change and its comes from this issue : Children prop is broken on Angular #1580

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 2d13a9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@seasheepjoe seasheepjoe marked this pull request as ready for review October 21, 2024 10:04
This reverts commit 5c1b65c.
This reverts commit 0ce66d3.
@samijaber
Copy link
Contributor

Thanks for the contribution @seasheepjoe 🙏🏽

@samijaber samijaber merged commit b9af061 into BuilderIO:main Oct 21, 2024
6 checks passed
Copy link

nx-cloud bot commented Oct 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2d13a9f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants