Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove use of soon to be deprecated method #1298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benmccann
Copy link

We've removed this method from Svelte 5

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mitosis-fiddle ❌ Failed (Inspect) Nov 6, 2023 4:47am

@@ -1,4 +1,4 @@
import { walk } from 'svelte/compiler';
import { walk } from 'estree-walker';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some breaking changes between the svelte/compiler.walk types we have and the latest estree-walker. The codebase is on svelte 3.53.1...I'm not sure what the changes are 🤔

Copy link

nx-cloud bot commented Nov 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3107e79. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx build @builder.io/mitosis
nx run-many --skip-nx-cache --target build --parallel 4 --exclude */e2e-alpine,*/e2e-angular,@builder.io/mitosis-fiddle,@builder.io/talk-*,@builder.io/example-apps

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants