-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map camle cased attributes to lower case #1122
Draft
moaoa
wants to merge
10
commits into
BuilderIO:main
Choose a base branch
from
moaoa:map-camle-cased-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
samijaber
requested changes
Apr 18, 2023
packages/core/src/__tests__/data/map-camle-cased-attributes.raw.tsx
Outdated
Show resolved
Hide resolved
samijaber
requested changes
Apr 24, 2023
packages/core/src/__tests__/__snapshots__/qwik.test.ts.snap.rej
Outdated
Show resolved
Hide resolved
packages/core/src/__tests__/__snapshots__/parse-jsx.test.ts.snap.rej
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pr to try and solve #526
what I added :
I followed the steps mentioned in the issue but my solution is not working out. Can anyone help me?
the snapshot still contains the attribute srcSet instead of srcset
here is the snapshot:
// Vitest Snapshot v1
exports[
map camle cased > map camle cased 1
] = `"<script>
import React from \"@builder.io/react\";
let name = \"Steve\";
</script>