Skip to content

Commit

Permalink
fix 1319 about the solid remove a property (#1369)
Browse files Browse the repository at this point in the history
* fix 1319 about the solid remove a property

* fix 1319 about the solid remove a property

* fix

* fix

* Update .changeset/flat-kangaroos-tan.md

---------

Co-authored-by: wuls <[email protected]>
Co-authored-by: Sami Jaber <[email protected]>
  • Loading branch information
3 people authored Jul 31, 2024
1 parent a340ab1 commit 3f5fff1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/flat-kangaroos-tan.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/mitosis': major
---

Solid: stop mapping `for` to `htmlFor`
2 changes: 1 addition & 1 deletion packages/core/src/generators/solid/blocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { collectClassString } from './helpers/styles';
import { ToSolidOptions } from './types';

const ATTTRIBUTE_MAPPERS = {
for: 'htmlFor',
// for: 'htmlFor',
};

const transformAttributeName = (name: string) => {
Expand Down

0 comments on commit 3f5fff1

Please sign in to comment.