Skip to content

Commit

Permalink
[smartling][deleteFeatureFlag] Removing feature flag check (#3728)
Browse files Browse the repository at this point in the history
## Description
The feature flag was temporarily added while users migrate their locales
from smartling to builder. We have communicated with the users. The
migration is completed and it has been turned off since long time. It is
now safe to delete it.

Once the pr is merged and plugin is deployed, will delete the feature
flag from launch darkly.
  • Loading branch information
anaghav2023 authored Nov 13, 2024
1 parent d8b64d4 commit 086405e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 2 additions & 2 deletions plugins/smartling/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugins/smartling/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@builder.io/plugin-smartling",
"version": "0.0.19",
"version": "0.0.20",
"description": "",
"keywords": [],
"main": "dist/plugin.system.js",
Expand Down
6 changes: 0 additions & 6 deletions plugins/smartling/src/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,6 @@ registerPlugin(
if(!isEqual(currentLocales?.enum, combinedLocales)){
appState.user.organization.value.customTargetingAttributes?.get('locale').set('enum', combinedLocales);
}
} else if(appState.hasFeatureFlag('manage-locales-in-smartling') && !isEqual(currentLocales?.enum, smartlingLocales)){
// overwrite all builder locales by smartling locales
appState.user.organization.value.customTargetingAttributes.set('locale', {
type: 'string',
enum: smartlingLocales,
});
}
});
// create a new action on content to add to job
Expand Down

0 comments on commit 086405e

Please sign in to comment.