Fixed promotion of [0] to * and -> only in specific cases #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently BuildIt promotes all operator[0] to * and ->. This is OKAY for pointers however for custom types with overloaded [0] operator actually breaks semantics. One example is std::vector, where vec[0].foo is not the same as vec->foo;
To get around this, BuildIt adds a metadata "deref_is_star" in cases where the operator[0] comes from a * or an ->
The code gen now upgrades these operators only when this metadata is present. Not promoting is always correct.
Sample33 and sample59 have been updated to test the same.