Skip to content

Commit

Permalink
fix(widget): enhance notifications
Browse files Browse the repository at this point in the history
enhance notifications default string value
  • Loading branch information
AlaaN-Smadi committed Dec 8, 2024
1 parent 5d653d4 commit 319e650
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 18 deletions.
32 changes: 16 additions & 16 deletions resources/languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -254,45 +254,45 @@
},
"newItemBody": {
"title": "New Item Created Message",
"defaultValue": "A ${context.plugin.title} has been created",
"defaultValue": "A ${context.plugin.itemTitle} has been created",
"inputType": "text",
"toolTip": "",
"maxLength": 150,
"placeholder": "A ${context.plugin.title} has been created"
"placeholder": "A ${context.plugin.itemTitle} has been created"
},

"backlogItemTitle": {
"title": "Task in Backlog Title",
"defaultValue": "Task in Backlog",
"title": "Task In Backlog Title",
"defaultValue": "Task In Backlog",
"inputType": "text",
"toolTip": "",
"maxLength": 50,
"placeholder": "Task in Backlog"
"placeholder": "Task In Backlog"
},
"backlogItemBody": {
"title": "Task in Backlog Message",
"defaultValue": "${context.plugin.title} has been marked as in backlog",
"title": "Task In Backlog Message",
"defaultValue": "${context.plugin.itemTitle} has been marked as In Backlog",
"inputType": "text",
"toolTip": "",
"maxLength": 150,
"placeholder": "${context.plugin.title} has been marked as in backlog"
"placeholder": "${context.plugin.itemTitle} has been marked as In Backlog"
},

"inProgressItemTitle": {
"title": "Task in Progress Title",
"defaultValue": "Task in Progress",
"title": "Task In Progress Title",
"defaultValue": "Task In Progress",
"inputType": "text",
"toolTip": "",
"maxLength": 50,
"placeholder": "Task in Progress"
"placeholder": "Task In Progress"
},
"inProgressItemBody": {
"title": "Task in Progress Message",
"defaultValue": "${context.plugin.title} has been marked as in Progress",
"title": "Task In Progress Message",
"defaultValue": "${context.plugin.itemTitle} has been marked as In Progress",
"inputType": "text",
"toolTip": "",
"maxLength": 150,
"placeholder": "${context.plugin.title} has been marked as in Progress"
"placeholder": "${context.plugin.itemTitle} has been marked as In Progress"
},

"completedItemBody": {
Expand All @@ -305,11 +305,11 @@
},
"completedItemMessageInputPlaceholder": {
"title": "Completed Task Message Input",
"defaultValue": "${context.plugin.title} has been marked as completed",
"defaultValue": "${context.plugin.itemTitle} has been marked as completed",
"inputType": "text",
"toolTip": "",
"maxLength": 150,
"placeholder": "${context.plugin.title} has been marked as completed"
"placeholder": "${context.plugin.itemTitle} has been marked as completed"
},
"completedItemMessageSendText": {
"title": "Completed Task Message Send Text",
Expand Down
4 changes: 2 additions & 2 deletions widget/controllers/widget.home.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ var config = {};
suggestion.statusName = $rootScope.TextStatuses[suggestion.status-1]
const voterIds = Object.keys(suggestion.upVotedBy);

votesExpressionOptions.plugin.title = suggestion.title;
votesExpressionOptions.plugin.itemTitle = suggestion.title;
Promise.all([
getLanguageValue("notifications.backlogItemTitle"),
getLanguageValue("notifications.backlogItemBody"),
Expand Down Expand Up @@ -975,7 +975,7 @@ var config = {};
suggestion.upvoteByYou = true;
$scope.suggestions.unshift(suggestion);
if($rootScope.settings){
votesExpressionOptions.plugin.title = suggestion.title;
votesExpressionOptions.plugin.itemTitle = suggestion.title;
Promise.all([getLanguageValue("notifications.newItemTitle"), getLanguageValue("notifications.newItemBody")])
.then(([title, message]) => {
if($rootScope.settings.pushNotificationUsersSegment === PUSH_NOTIFICATIONS_SEGMENT.ALL_USERS){
Expand Down

0 comments on commit 319e650

Please sign in to comment.