-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real metric names #99
Real metric names #99
Conversation
with a weight multiplier of 1 so that it doesn't actually have a weight. just to appease TS
to remove mapping
@swellander is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Appreciate you doing this. One issue is that we will still need the mapping. The source for the metric names was a static data set that had the mapping already added to each project but in the future we will pull the data from a different source and it is unlikely that this data will include the mapping data. Feel free to reach out for more clarity.
cffcb1b
to
28c1bc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Updates our metric names and OSO data to be in sync with the current version of OSO's API. Running a yarn seed --reset is needed for this branch to work locally
Additional Information
seed.sample.json
with the new metricsmapping
object, that we no longer need because OSO includes anapplication_id
field that is also the project's ID on Agora.