Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tweaks #3

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Design tweaks #3

merged 2 commits into from
Nov 5, 2024

Conversation

andrealbiac
Copy link
Contributor

@andrealbiac andrealbiac commented Oct 30, 2024

Hey! Made a few tweaks to adjust some things that felt a bit off, like:

  • Left margin of the page and paddings between elements that felt too cramped. The change is subtle but adding more felt a bit too much
  • Text sizes that were too small
  • Aligned the stream-contract component to the center so the space it's a bit more even on the sides
  • Also replaced the logo with a new one that is more legible and doesn't have a subtitle (I think you don't need one in this case? and it was also too small)
  • Deleted unused logos

Attatching some pictures of the changes:
Captura de pantalla 2024-10-30 a las 16 58 38
Captura de pantalla 2024-10-30 a las 16 58 18
Captura de pantalla 2024-10-30 a las 16 58 14

Let me know what you think of it!
Thanks

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-buidlguidl-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:29pm

@carletex
Copy link
Contributor

Somethig is breaking on mobile

image

@andrealbiac
Copy link
Contributor Author

Ah true, I forgot to check the responsive 😅 sorry, will update soon

@andrealbiac
Copy link
Contributor Author

andrealbiac commented Nov 1, 2024

Hey! How can you get to that view on localhost? This is the narrowest I can get to see it (and there everything is fine) ->

Captura de pantalla 2024-11-01 a las 12 33 45

Maybe it's another tool or viewport that lets you view it as in mobile?

@carletex
Copy link
Contributor

carletex commented Nov 4, 2024

(and there everything is fine)

Yes, but that's not a mobile view, that's more like a tablet.

With Chrome you can use this:

image

which opens this:

image

@andrealbiac
Copy link
Contributor Author

Oh wow thanks! Didn't know that, fixing it asap 🫡

@andrealbiac
Copy link
Contributor Author

andrealbiac commented Nov 5, 2024

So I've been trying everything and can't find how to change this width, it's so weird

It seems like it's some global setting that controls the general layout but it's not in the globals.tsx, or the app.tsx,also not any parent container with max-width. Also couldn't fix it with the AI help of Cursor editor.

Maybe we can ask @mac11fish to help with it, or some internal BG reviewers?
Hope I'm not missing something super obvious

@carletex
Copy link
Contributor

carletex commented Nov 5, 2024

Pushed a couple of tweaks to fix the view on mobile 3951383

The main issue was w-[500px] (you were setting a fixed width container that doesn't fit on mobile) + removed the tooltip that wasn't being used (was text-white :D). Also, change "Connect Wallet" to "Connect" to the logo + connect button fix.

@carletex carletex merged commit 30d3bce into BuidlGuidl:main Nov 5, 2024
1 of 2 checks passed
@andrealbiac
Copy link
Contributor Author

Oh but it was in the Stream contract component! Okay didn't think it could be because of that, thanks!

@mac11fish
Copy link

sorry guys,
Had my Github account linked to my old email address.
Wasn't getting notifications.
it's switched now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants