Design changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2024 17:07
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carletex
requested changes
Oct 25, 2024
added 2 commits
October 25, 2024 13:46
|
thanks for the comments |
carletex
reviewed
Oct 25, 2024
carletex
reviewed
Oct 25, 2024
added 2 commits
October 26, 2024 01:12
carletex
reviewed
Oct 28, 2024
|
Hey, I think I resolved all the requests. Let me know please, if there is something missing. |
|
Hey @mac11fish ! Yes, everything solved code-wise! Merging this. Thanks ;) I see some little things (Design wise)
Here it seems like some space is missing? But I'll leave that to @andrealbiac for another PR Thanks again!! |
|
Hey I fixed that issue with the missing space, no problem. |
|
also noticed a small issue with button text same color as button background. I fixed this issue. Will submit a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestive design changes for media.buidlguidl.com