Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style tweaks #31

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Style tweaks #31

merged 8 commits into from
Feb 19, 2024

Conversation

swellander
Copy link
Collaborator

@swellander swellander commented Feb 19, 2024

Screen.Recording.2024-02-19.at.9.46.40.AM.mov

Description

Makes a few style changes to mirror the figma a bit more.

Note

Based off of @0xChijoke 's recent PR #30, which should be reviewed and merged before this PR.

Additional Information

  • Removes the stock SE2 header/footer
  • Adjusts padding
  • Color and size of sliders
  • Adds column sorting to vector table
  • Changes Line chart to Area chart with (an attempt) at the linear gradient
  • Adds smaller project images to each x-axis tick

Remaining style TODOs

  1. Make linear gradient color actually match the figma. I'm not too familiar with them and wasn't too successful but maybe someone else can have a go?
  2. Z-index of hovered project images needs adjusting. Smaller project images to the right of the hovered image still render on top
  3. Placeholder image for projects without one
  4. I don't think the mac-app-bar-style image rendering works too well when adding more vectors and projects. If y'all think it looks too crowded, maybe we could limit the number of projects rendered on the graph, or just put the image in the tooltip that renders near the cursor.

Related Issues

Related to Issue #25

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
impact-calculator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 7:59pm

@swellander
Copy link
Collaborator Author

Rebased with main

Comment on lines +143 to +146
<linearGradient id="colorTotal" x1="0" y1="1" x2="0" y2="0">
<stop offset="5%" stopColor="rgba(20, 124, 73, 0.1)" stopOpacity={0.8} />
<stop offset="95%" stopColor="#FBDD5D" stopOpacity={0} />
</linearGradient>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the linear gradient definition, and here's the css for the gradient from figma:

background: linear-gradient(180deg, rgba(20, 124, 73, 0.1) 0%, #FBDD5D 100%);

but keep rainbowkit and wagmi providers
Copy link
Collaborator

@escottalexander escottalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Nice work!

@escottalexander escottalexander merged commit ad8b89a into BuidlGuidl:main Feb 19, 2024
3 checks passed
@swellander swellander deleted the style-tweaks branch February 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants