Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submissions page #74

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Add submissions page #74

merged 2 commits into from
Sep 5, 2024

Conversation

damianmarti
Copy link
Member

localhost_3000_submissions

@damianmarti damianmarti requested a review from carletex September 4, 2024 19:59
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
extensions-hackathon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:48am

Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damianmarti

Posted a few comments, but just fixed it in d50a1eb since it was small things

@@ -0,0 +1,31 @@
"use client";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it!

import type { NextPage } from "next";
import { getAllSubmissions } from "~~/services/database/repositories/submissions";

const Admin: NextPage = async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the name to "Submissions"

import { SubmissionCard } from "./_components/SubmissionCard";
import type { NextPage } from "next";
import { getAllSubmissions } from "~~/services/database/repositories/submissions";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some metadata-

@carletex carletex merged commit a0fb798 into main Sep 5, 2024
3 checks passed
@carletex carletex deleted the submissions-page branch September 5, 2024 08:50
@damianmarti
Copy link
Member Author

Thanks @damianmarti

Posted a few comments, but just fixed it in d50a1eb since it was small things

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants