Create sticky box and add it to the landing page #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pabl0cks
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Awesome job @portdeveloper !! Looks great to me 🙌
Pushed a couple of small tweaks:
- Move the box a bit inside to not pass the borders of the homepage
- Make the component a bit bigger for the big screens. Don't have access to my desktop screen but I feel it would look a bit small there. Can rollback if I was wrong! 🙏
- Add real dates and tg link
Merging this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
msedge_bNCpNgweRs.mp4
If we remove the X on the sticky, the user gets very little space to actually see the website given that the iphones already eat so much of onscreen space:
Fixes #31