Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin comments to submissions #18

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Add admin comments to submissions #18

merged 6 commits into from
Aug 12, 2024

Conversation

damianmarti
Copy link
Member

Allow admin users to add comments to each submission.

closes #15

@damianmarti damianmarti requested a review from carletex August 9, 2024 13:51
@damianmarti
Copy link
Member Author

@technophile-04 @rin-st for review

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damianmarti ! Overall working good, added some comments

And also date and textarea looking strange, I think it's better to fix it, just to not forget about them
Screenshot 2024-08-09 at 18 26 39

@damianmarti
Copy link
Member Author

Thanks @damianmarti ! Overall working good, added some comments

And also date and textarea looking strange, I think it's better to fix it, just to not forget about them Screenshot 2024-08-09 at 18 26 39

Yeah, sure, I didn't spend too much time with styles now and I focused on features

@damianmarti
Copy link
Member Author

damianmarti commented Aug 9, 2024

Thanks @damianmarti ! Overall working good, added some comments

And also date and textarea looking strange, I think it's better to fix it, just to not forget about them Screenshot 2024-08-09 at 18 26 39

@rin-st For the date and time text, do you think that makes sense to use dayjs or something like that, or can we just format the date using the regular Date functions?

@rin-st
Copy link
Member

rin-st commented Aug 9, 2024

@rin-st For the date and time text, do you think that makes sense to use dayjs or something like that, or can we just format the date using the regular Date functions?

I think regular is enough, something like this

@damianmarti
Copy link
Member Author

@rin-st For the date and time text, do you think that makes sense to use dayjs or something like that, or can we just format the date using the regular Date functions?

I think regular is enough, something like this

Yeah, but I should add hours and minutes here, I think it's important for the comments.

@damianmarti damianmarti requested a review from rin-st August 9, 2024 21:20
Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@technophile-04
Copy link
Member

Thanks @damianmarti!! Just pushed a couple of commits.

  1. Keeping the Submissions component as server component. I think you made it client component because you wanted to refetch data after mutation? We could also achieve it by using refresh from useRouter. NextJs won't refresh the whole page instead it will update the data smartly.

  2. Using default network as sepolia this way we don't need to run yarn chain until we have the contract

@technophile-04 technophile-04 merged commit 4235af8 into main Aug 12, 2024
1 check passed
@damianmarti
Copy link
Member Author

Thanks @damianmarti!! Just pushed a couple of commits.

  1. Keeping the Submissions component as server component. I think you made it client component because you wanted to refetch data after mutation? We could also achieve it by using refresh from useRouter. NextJs won't refresh the whole page instead it will update the data smartly.
  2. Using default network as sepolia this way we don't need to run yarn chain until we have the contract

Thanks @technophile-04 !!

Yes, I thought it would be better to refetch only the submissions after mutation.

@damianmarti damianmarti deleted the admin-comments branch August 12, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin: Allow to add and see comments
3 participants