Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add txChainId to grants #72

Merged
merged 9 commits into from
Mar 13, 2024
Merged

Add txChainId to grants #72

merged 9 commits into from
Mar 13, 2024

Conversation

technophile-04
Copy link
Member

Description

Kept it simple for this PR, passing in the txChainId on which the admin is connected / will be making the request.

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 7:55pm

@carletex
Copy link
Contributor

carletex commented Mar 8, 2024

Great stuff @technophile-04 !!

A couple of things we talked about this morning:

  • On submitted grants: dIsabled SEND 50 % button (+ tooltip explaining) when the chainID in the grant !== connected account
  • We want to show all of them regarding the chain the admin is in (I think this is already happening, right?)

Also:
How about an HTML select on the complete / approve modal alongside the txHash input?? (options could be listing the ids/names of the configured in scaffold.config? This will help for the same reason we have the input.... in case the admin close the window, etc.

A good alternative: just show the chain ID in the modal (without the HTML select) to show the current chain the admin is connected. Probable we want to start with this option!

What do you think?

@technophile-04
Copy link
Member Author

On submitted grants: dIsabled SEND 50 % button (+ tooltip explaining) when the chainID in the grant !== connected account

Updated at 402787d

Screen.Recording.2024-03-11.at.7.54.56.PM.mov

A good alternative: just show the chain ID in the modal (without the HTML select) to show the current chain the admin is connected. Probable we want to start with this option!

Being lazy and went with this for now 😅 at 4ccdfb5 , but we could totally go with select please let me know or maybe we can tackle in another PR

@technophile-04 technophile-04 requested a review from carletex March 12, 2024 12:09
@carletex carletex merged commit 0d7bcf8 into main Mar 13, 2024
3 checks passed
@carletex carletex deleted the store-chainId branch March 13, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants