Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch actions #61

Merged
merged 20 commits into from
Mar 6, 2024
Merged

Batch actions #61

merged 20 commits into from
Mar 6, 2024

Conversation

technophile-04
Copy link
Member

Description :

Playing around with batch actions

Branched out from #59, we could merge #59 and will later backmerge main into this 🙌

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 10:52am

@technophile-04
Copy link
Member Author

Demo :

Screen.Recording.2024-03-06.at.12.45.41.PM.mov

Currently, the assumption is that all batch actions have the same txnHash (for now it's hardcoded but we can it later once we have the contract maybe) also please feel free to nitpick !!

@carletex
Copy link
Contributor

carletex commented Mar 6, 2024

Amazing stuff @technophile-04 Pushed a little tweak.

Currently, the assumption is that all batch actions have the same txnHash

Yep, great. We'd add a "send 50% Batch" button that interacts with the contract. I think I'm goona create a PR with a dummy contract so we can implement this. Also might change the networks (testnet + hardhat) so we can test properly.

@carletex carletex merged commit 66fff58 into main Mar 6, 2024
3 checks passed
@carletex carletex deleted the batch-actions branch March 6, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants