Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed grants cards new design and section bg color #57

Merged
merged 11 commits into from
Mar 2, 2024

Conversation

Pabl0cks
Copy link
Member

@Pabl0cks Pabl0cks commented Mar 1, 2024

Description

New design for completed grants cards and bg color of the section.

Tried to follow figma design, but after talking with Andrea we've capped title lines to 2, because it felt too much height if they had 1 line. Only 1 of the current completed grants has more than 2 lines, we thought we could always increase it to 3 lines in the future if we see longer titles.

LMK any changes you'd make 🙌 I'll tackle spacing of all sections and update stats icons in different PRs.

Closes #52

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 7:00pm

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM @Pabl0cks really nice, looking great !!!

we've capped title lines to 2, because it felt too much height if they had 1 line.

Yeah I think it makes sense and also looks nice

@technophile-04 technophile-04 merged commit d574a29 into main Mar 2, 2024
3 checks passed
@technophile-04 technophile-04 deleted the completed-grants-newdesign branch March 2, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak completed grants card styles and section bg color
2 participants