Reduced view for completed grants at Homepage + view all button #51
Conversation
Pabl0cks
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Tysm @Pabl0cks this is great !!!
max limit of 8 grants, and then manually forcing on every breakdown to load 2 rows of cards, except on mobile where is loading 3 (2 cards felt too little). Couldn't think of an cleaner way to implement, and 8 cards felt huge on mobile-tablet.
I am not sure either what's the best solution would be to handle this, but your solution looks and works nicely !!
Just thought came to mind, In very late future we could handle this in backend too using firebase limit so that we only query 8 documents on home page....but lol not at all required to do now !
|
Thanks for the review @technophile-04!!
Ohh didn't know that limit existed in firebase, makes sense! ShivGPT > chatGPT 😄🙌 |
|
Merging this one to create a new PR to iterate on the completed grants design, any changes regarding this PR can be tackled there 🙌 |
Description
Added a new page to show all completed grants, and a reduced view (via prop) to show at Homepage.
Reduced view has a max limit of 8 grants, and then manually forcing on every breakdown to load 2 rows of cards, except on mobile where is loading 3 (2 cards felt too little). Couldn't think of an cleaner way to implement, and 8 cards felt huge on mobile-tablet.
In the future we can make a similar approach for Ecosystem impact grants, or go for a carousel there instead if the number feels optimal for it.
Closes #36