Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats tweaks #42

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Stats tweaks #42

merged 7 commits into from
Feb 26, 2024

Conversation

technophile-04
Copy link
Member

@technophile-04 technophile-04 commented Feb 25, 2024

Description

  1. Removed submission value
  2. Total grants is sum of "completed" grants + "approved" grants
  3. Active grants are "approved" grants
  4. Moved Impact gratnts to Json file
  5. While displaying stats add impact grants to calculation
  6. Updated icons (I think they are still WIP, but we can update them later again)

Can be tested with Pablo's PR seed data, but here is demo :

Screen.Recording.2024-02-25.at.9.50.33.PM.mov

Lol please don't go on branch name forgot to change it before creating PR

Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:01am

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great to me! GJ @technophile-04

Only pushed a small nitpick, stats felt too close in some particular resolution, but it could have stayed like that probably :)

@Pabl0cks
Copy link
Member

Let's wait for Carlos thoughts here but this PR iteration seems great to me, we could tackle posible changes in another PR.

@carletex
Copy link
Contributor

Looking great!!

@carletex carletex merged commit 73989ce into main Feb 26, 2024
3 checks passed
@carletex carletex deleted the complete-grants-cards branch March 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants