Hero section minor tweaks #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pabl0cks
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Awesome job again @technophile-04!
Did a small nitpick push to add a bit of spacing in lg breakpoint.
| Before | After |
|---|---|
 |
 |
Was not sure about spacing in xl breakpoint, so left it at 0 for now. Asked Andrea about 3 different variants (py-12 - py-6 - py-0), Not a big difference so if you see it clear, go for it, or we wait a few hours.
Screenshot with the different cases (1, 2 and 3).
Bugs me a little bit on mobile the behavior of RainbowKit dropdown and balance when you have a connected Account, not sure how clean/hacky is to tweak the RainbowKit component. We can tackle it (if so) in another PR 🙌
| Current | Tweaked |
|---|---|
 |
 |
TYSM Shiv, you can clearly see I loved your sshot formatting hahah
Sorry for nitpicking like that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #34 for now we could update copy of desc later 🙌