-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load initial data for grants and hide dark mode toggle #39
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey Pablo, could you also please update :
to Because if not, it will launch the website in dark mode if the users |
TYSM Shiv!! I'd probably missed that one, because it was loading on Light to me after testing other branch 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Pabl0cks !
Left a few comments and open questions!
Yes! Let's do this (so we have data for WIP grants) |
@technophile-04 going back for a bit to the dark mode disabling, for some reason in my laptop I had localstorage "theme" set as "dark" (first time loading grants, and OS set to light), and it wouldn't change to "light" refreshing. Doing some tests:
Should we temporary use TYSM |
Ohh yes !! This makes sense , Lets do it for now until we have proper dark theme, Tsym 🙌 |
To prevent any edge case loading dark mode and not being able to switch to light
Ok great! Pushed this change.
Done!
TYSM for the review! Just pushed the changes to fix the comments, hope I didn't miss any! 🙌 |
Thanks all! Made some tweaks before merging:
(Feel free to tweak for local testing)
|
fc4066e
to
90538e8
Compare
Load initial data for grants, grabbing the final projects completed from Batches 0 and 1.
Data questions:
"status": "approved"
for now.Not related but also hided the dark mode toggle button until we implement dark mode.
Closes #29
Closes #30