Admin tweaks - Delete stream badges and change logic for build submission rejections #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carletex
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Tested it and it's working great. Thanks @Pabl0cks
I think this is the most simple & clean solution. It might introduce some confusion (people seeing their grant as "approved" again... but with a rejected note :D), but I think it's a good first iteration.
We can always add a new state "reject-build" in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Couple of tweaks in /admin:
When a grant is in approved status, users can submit their builds to be able to complete their grant and receive the rest of their grant amount (if admins approve the build proposal).
In case the build is not complete, and admins want to reject the build submissions, changed the logic of reject action, to change the status of the grant to "approved" instead of "rejected", so users can resubmit the build when they fix their problems. The condition I'm checking is if the current status of the grant prior executing the rejection logic was "submitted".
The reject/approval notes were always showing in /my-grants for grants in approved status, so didn't need to tweak it.
Closes Kick back build submissions #123
Also deleted stream badges since regular streams don't exist anymore.
Closes Delete regular stream info from submissions at /admin #124