Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total count on admin view for New grants and Completed grants #121

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

Pabl0cks
Copy link
Member

Fixes #120

Not showing totals if there are no elements, can delete that check if it makes more sense 🙌

image

Wondering if it would be nice to add totals also in the "Send batch" buttons, something like:

image

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 11:24am

@Pabl0cks Pabl0cks requested a review from carletex April 24, 2024 08:19
@carletex
Copy link
Contributor

Looking good!

Wondering if it would be nice to add totals also in the "Send batch" buttons, something like:

Yep, I like this!

@Pabl0cks
Copy link
Member Author

Yep, I like this!

Just pushed it!

Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @Pabl0cks

Thanks!

@carletex carletex merged commit d34fcc0 into main Apr 25, 2024
3 checks passed
@carletex carletex deleted the admin-grant-totals branch April 25, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show count on admin view
2 participants