Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update featured grants images to fix aspect ratio #119

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

Pabl0cks
Copy link
Member

@Pabl0cks Pabl0cks commented Apr 22, 2024

Fixes #114

Haven't used the biggest version of Jessy's because probably we don't need super definition on people's faces, and that way overall image size doesn't grow much.

Adding a couple of screenshots so you can check if everything looks OK @andrealbiac

Screenshot post update on laptop:

image

Screenshot post update on desktop (with some zoom):

image

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 1:14pm

@carletex
Copy link
Contributor

I remember this happening before: A pixel around the images. I think it was related to some shadow applied on Figma.

image

Copy link

@andrealbiac andrealbiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True the damn shadow. Yeah at first we thought it was a shadow effect in Figma but it wasn't that, we didn't find the reason and I ended up making screenshots of it 🤓 But I completely forgot about that, thanks for noticing Carlos!

I still can't find why that happens so let's upload screenshots again. No need to review after this cause the quality looks fine 🫡

So I'll just send them here: (hope it makes sense to add it in the review - first time reviewing a PR)

bytes032 eth erhant eth jtriley eth w1nt3r-evm solidity-by-example jessys-hacker-house

Thanks guys!!

@Pabl0cks
Copy link
Member Author

Thanks @carletex for the good eye and @andrealbiac for the updated assets. I forgot about that problem and thought the empty border was intended, sorry! 😓

I've just updated them with the last ones, compacted them a bit to reduce the file size.

Copy link

@andrealbiac andrealbiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. And yeah it's so difficult to see that! I also didn't notice the first time lol

Thanks Pablo! 😊 Also for compacting them, will do that next time

@Pabl0cks Pabl0cks merged commit e58bff5 into main Apr 23, 2024
3 checks passed
@Pabl0cks Pabl0cks deleted the update/feat-grants-images branch April 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Featured grants image aspect ratios
3 participants