-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update featured grants images to fix aspect ratio #119
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True the damn shadow. Yeah at first we thought it was a shadow effect in Figma but it wasn't that, we didn't find the reason and I ended up making screenshots of it 🤓 But I completely forgot about that, thanks for noticing Carlos!
I still can't find why that happens so let's upload screenshots again. No need to review after this cause the quality looks fine 🫡
So I'll just send them here: (hope it makes sense to add it in the review - first time reviewing a PR)
Thanks guys!!
Thanks @carletex for the good eye and @andrealbiac for the updated assets. I forgot about that problem and thought the empty border was intended, sorry! 😓 I've just updated them with the last ones, compacted them a bit to reduce the file size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. And yeah it's so difficult to see that! I also didn't notice the first time lol
Thanks Pablo! 😊 Also for compacting them, will do that next time
Fixes #114
Haven't used the biggest version of Jessy's because probably we don't need super definition on people's faces, and that way overall image size doesn't grow much.
Adding a couple of screenshots so you can check if everything looks OK @andrealbiac
Screenshot post update on laptop:
Screenshot post update on desktop (with some zoom):