Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2 - abdulkadir personal page #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue #2 - abdulkadir personal page #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions packages/nextjs/app/builders/0x6d3321b4637D8451740Cf400848602f838F7A594/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import React from "react";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to explicitly import React in Next.js anymore, starting from Next.js 12.2 and React 17 and above. With these versions, Next.js automatically imports React when needed, so you can safely omit import React from "react" at the top of your files.

import { FaGithub } from "react-icons/fa";
import { SiGmail } from "react-icons/si";
import { Address } from "~~/components/scaffold-eth";
import { BlockieAvatar } from "~~/components/scaffold-eth";

const PersonalPage = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page.

Also you could consider it after your name since there are are many more personal pages.

return (
<div className=" flex justify-center items-center">
<div>
<div className=" pt-24 lg:pt-[100px]">
<div className="flex flex-col-reverse lg:flex-row items-center justify-center gap-x-[50px] md:mx-[550px]">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check the mobile responsiveness, as it appears differently on smaller screens, as shown in the picture.

Screenshot 2024-09-26 at 18 28 34

<div className=" w-full">
<h1 className=" text-[40px] font-bold md:my-[1rem]">Hello 👋🏼</h1>
<p className=" text-[14px] md:text-lg p-1 font-semibold w-full text-justify mb-[6px]">
My name is Abdulkadir. I want to become a doctor in the future. I really like computer games. I try to
balance my studies with my hobbies.
</p>
<div className=" flex items-center gap-x-2 -my-3">
<p>Address :</p>{" "}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-26 at 18 24 35

It looks like the : is appearing on the next line (on smaller screen sizes). It would be great to have it in on line with Address.

And doublecheck if you need {" "}

<div className="bg-primary-content text-secondary px-3 py-2 rounded-[10px] my-3">
<Address address="0x6d3321b4637D8451740Cf400848602f838F7A594" />
</div>
</div>

<div className=" flex items-center justify-center lg:justify-start gap-5 text-[20px] lg:text-[23px] my-1 ">
<a
href={"https://github.com/0xabdulkadir"}
target="_blank"
rel="noopener noreferrer"
className=" hover:text-accent duration-300 ease-in-out text-[1.8rem]"
>
<FaGithub />
</a>

<a
href="mailto:[email protected]"
className=" hover:text-accent duration-300 ease-in-out text-[1.8rem]"
>
<SiGmail />
</a>
</div>
</div>

<div className=" relative rounded-full overflow-hidden h-auto w-[270px] md:mb-20">
<BlockieAvatar address="0x6d3321b4637D8451740Cf400848602f838F7A594" size={270} />
</div>
</div>
</div>
</div>
</div>
);
};

export default PersonalPage;