Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4 - created new home page #30

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Issue 4 - created new home page #30

merged 10 commits into from
Sep 23, 2024

Conversation

ishtails
Copy link
Contributor

@ishtails ishtails commented Sep 18, 2024 •
edited
Loading

Description

Created a new design for the home page of our website with the following:

  • responsive layout
  • dark & light mode

Other Changes:

  • changed site title in metadata to BuidlGuidl Batch 9
  • tweaked global colors to match the new theme

Future Scope:

  • add a builder page with check-in counter in similar design pattern.
  • add animations if required.

Additional Information

Related Issues

_Closes Issues #7 (Tweak Home Page) & #5 (Show Connected Wallet Info)

Your ENS/address: 0x5D56b71abE6cA1Dc208Ed85926178f9758fa879c

Screenshots:

light_mode
dark_mode

@ishtails
created new home page
713fee8 
- responsive.
- dark / light mode.
@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch9-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 10:58am

@ishtails ishtails changed the title created new home page Issue 4 - created new home page Sep 18, 2024
@phipsae phipsae self-requested a review September 19, 2024 13:31
@phipsae phipsae assigned phipsae and ishtails and unassigned phipsae Sep 19, 2024
phipsae
phipsae requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishtails Thanks so much for the beautiful homepage, that was definitely a lot of work! It looks fantastic, especially how you used the colors and embedded "batch member".

Don't worry about my comments below—they should be quick and easy to implement!
If you have any question let me know.

packages/nextjs/components/Footer.tsx Outdated Show resolved Hide resolved
packages/nextjs/assets/banner bg.png Outdated Show resolved Hide resolved
packages/nextjs/assets/blue_yellow.svg Outdated Show resolved Hide resolved
packages/nextjs/assets/blur_blue.svg Outdated Show resolved Hide resolved
packages/nextjs/assets/cryptopunks.png Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
@ishtails
Copy link
Contributor Author

@phipsae i have made all your requested changes. please review and see if everything looks good!

phipsae
phipsae requested changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, really appreciate your work!

Almost done with the PR, you'll find below some tiny comments.

packages/nextjs/components/Arrow_Icon.tsx Outdated Show resolved Hide resolved
packages/nextjs/components/Card.tsx Outdated Show resolved Hide resolved
@ishtails
ui fixes
72e13ed 
 - fixed the arrow_icon's SSR issue (added wait till mount)
- removed hover effect from non-clickable card section
- commented out the header wallet info (redundant)
- fixed footer visibility issue for local (hardhat) layout as well
@ishtails
added a check for builder page
0ab8407 
- added a useEffect to check if builder page exists
@phipsae
Copy link
Collaborator

phipsae commented Sep 23, 2024

And I say it again: thanks for the really nice page :)

@phipsae phipsae merged commit 62d5bac into BuidlGuidl:main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phipsae phipsae phipsae requested changes

Assignees

@ishtails ishtails

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishtails @phipsae