Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2: fedev | Personal Page #13

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

fedeloterstein
Copy link
Contributor

@fedeloterstein fedeloterstein commented Sep 11, 2024

Description

In this PR we worked on:

  • Creating the builders folder
  • Creating my personal page
  • Support for dark mode.
Captura de pantalla 2024-09-10 a la(s) 21 07 09 Captura de pantalla 2024-09-10 a la(s) 21 07 21

Additional Information

Related Issues

_Closes #9

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address: 0xDFbE6c0A54F9f4f758753aE56eDD02Dd92C29be3

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch9-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 3:46am

@fedeloterstein fedeloterstein changed the title feat: fedev personal page Issue 2: fedev Sep 11, 2024
@fedeloterstein fedeloterstein changed the title Issue 2: fedev Issue 2: fedev | Personal Page Sep 11, 2024
@phipsae phipsae requested review from phipsae and carletex and removed request for carletex and phipsae September 12, 2024 07:11
@carletex carletex requested a review from phipsae September 12, 2024 09:20
Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedeloterstein, great job on the clean and well-organized code for your personal page!

Just a small suggestion—consider adding a personal touch, like a picture (it doesn’t necessarily have to be of you), to make it stand out even more.

I've also left a minor comment below.

packages/nextjs/contracts/deployedContracts.ts Outdated Show resolved Hide resolved
@fedeloterstein
Copy link
Contributor Author

@fedeloterstein, great job on the clean and well-organized code for your personal page!

Just a small suggestion—consider adding a personal touch, like a picture (it doesn’t necessarily have to be of you), to make it stand out even more.

I've also left a minor comment below.

I've already made an update. I liked this way of keeping a clean profile, not so overloaded. Sometimes less is more.
Captura de pantalla 2024-09-13 a la(s) 00 44 55

@phipsae
Copy link
Collaborator

phipsae commented Sep 13, 2024

@fedeloterstein, great job on the clean and well-organized code for your personal page!
Just a small suggestion—consider adding a personal touch, like a picture (it doesn’t necessarily have to be of you), to make it stand out even more.
I've also left a minor comment below.

I've already made an update. I liked this way of keeping a clean profile, not so overloaded. Sometimes less is more. Captura de pantalla 2024-09-13 a la(s) 00 44 55

Thanks! I agree on that :)

Merged.

@phipsae phipsae merged commit bc17067 into BuidlGuidl:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants