Fix #21 - Add Padding and icons #28
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks, @NightmareFox12, for this PR! The code is very neat and clear.
I just have a small comment.
As general advice for future PRs, please make sure to create and check out a new branch. Also, consider providing a more detailed description. You can refer to Zak's contribution guidelines here: https://gist.github.com/ZakGriffith/69d1eb8baebddd7d370b87a65a7e3ec0.
...extjs/app/builders/0xD2692F9df925D18D527ABe8b3d99EE9E9C8d75AE/_components/SkillComponent.tsx
Outdated
Show resolved
Hide resolved
| <div className="flex flex-col items-center md:items-start gap-6"> | ||
| <div className="rounded-full w-40 h-40 md:w-56 md:h-56 overflow-hidden border-red-500 border-2"> | ||
| <Image | ||
| src={nightmareFoxImage} |
There was a problem hiding this comment.
You can also do src={"/builders/avatars/0xD2692F9df925D18D527ABe8b3d99EE9E9C8d75AE.jpg"}
This approach works because it's using a public path. In Next.js, files inside the public directory are served at the root path.
There was a problem hiding this comment.
Thanks for the updates @NightmareFox12 !! Looking good to me 🙌
|
@NightmareFox12 is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
#21