Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pena Personal Page #26

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Added Pena Personal Page #26

merged 7 commits into from
Aug 29, 2024

Conversation

penaMaster
Copy link
Contributor

Description

Ekran Resmi 2024-08-21 10 13 05

Additional Information

Related Issues

Your ENS/address: 0x8eE31084d2914fA84Baae3460093564934837898

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch8-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 11:49am

Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @penaMaster

Thanks for the PR! I left some review comments, you can fix them and push in this same PR so it gets updated.

Let me know if you need any help!

@penaMaster
Copy link
Contributor Author

Hello,I edited some stuff.

Ekran Resmi 2024-08-27 14 29 41

Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Almost there, but there are some linting errors still:

image

For the img, since they are external, maybe you can just eslint-disable-next-line them. And the other error is prettier (if you configure your IDE on save, it should take of it).

You can also run yarn lint locally to check this errors out.

Thanks!

@penaMaster
Copy link
Contributor Author

Hello,

I am using tag also,but still giving warnings. So I disabled them.

Thanks!

Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the linting for the whole file is not the (right) solution! You can ignore specific lines (eslint-disable-next-line) or just use the right components/tags (<Image>)

Let me know if you have any specific issues.

@penaMaster
Copy link
Contributor Author

Hi @carletex,

All done with no error. Can you check again?

Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great now, thanks!!

@carletex carletex merged commit 952cdfa into BuidlGuidl:main Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants