-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Pena Personal Page #26
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @penaMaster
Thanks for the PR! I left some review comments, you can fix them and push in this same PR so it gets updated.
Let me know if you need any help!
packages/nextjs/app/builders/0x8eE31084d2914fA84Baae3460093564934837898/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8eE31084d2914fA84Baae3460093564934837898/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8eE31084d2914fA84Baae3460093564934837898/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8eE31084d2914fA84Baae3460093564934837898/page.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Almost there, but there are some linting errors still:
For the img
, since they are external, maybe you can just eslint-disable-next-line
them. And the other error is prettier (if you configure your IDE on save, it should take of it).
You can also run yarn lint
locally to check this errors out.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling the linting for the whole file is not the (right) solution! You can ignore specific lines (eslint-disable-next-line
) or just use the right components/tags (<Image>
)
Let me know if you have any specific issues.
Hi @carletex, All done with no error. Can you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great now, thanks!!
Description
Additional Information
Related Issues
Your ENS/address: 0x8eE31084d2914fA84Baae3460093564934837898