Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Selpak Personal Page #22

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Selpak99
Copy link

@Selpak99 Selpak99 commented Aug 17, 2024

Description

This is my personal page

image
image

Additional Information

Related Issues

Your ENS/address: 0x357bc010520575Ea5720aC3F7cb48fcedfc711Ed

Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch8-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:11pm

@edakturk14
Copy link
Contributor

Hey @Selpak99!

Thank you for your work! Here are a few changes to improve and make the checks pass:

  1. Prettier Formatting: The code doesn't follow the Prettier configuration. Such as:

    • Inconsistent use of quotes (mix of single and double quotes)
    • Missing semicolons at the end of statements
    • Long lines that could be wrapped for better readability
      Running the code through Prettier will automatically fix these issues.
  2. Component Naming: The component is currently named page (lowercase). In React, component names should use PascalCase. Please rename it to Page to follow this convention.

  3. The onClick handlers are attached directly to icon components. This can be problematic for keyboard navigation and screen readers. Consider wrapping these in button elements:

Github
  1. External Links: For security, consider adding rel="noopener noreferrer" to links opened with window.open().

These changes will significantly improve the code quality and follow to best practices. Let me know if you need any clarification or assistance with implementing these suggestions!

@Selpak99
Copy link
Author

Hi @edakturk14 ,

I think I fixed. Can you check please?

Copy link

vercel bot commented Aug 30, 2024

@Selpak99 is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@Selpak99
Copy link
Author

I fixed prettier error. Ready to merge

@Selpak99
Copy link
Author

Hi @edakturk14 ,

I changed to . You can look at them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants