-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List the members of the batch #18
List the members of the batch #18
Conversation
- Displayed the static total builder count. - Created a section for listing builder addresses. - Implemented links that direct users to a specific builder's profile upon clicking the address.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Removed the`MemberAaddress.tsx` component and took the whole code into the `MembersList.tsx` componet.
-Disabled links and dimmed opacity for builders without profile pages, ensuring users aren't redirected to 404 pages. -Highlighted addresses of builders with completed profile pages, making it easy to spot active profiles.
Hey @rohan-ahire06! Slick looking design. I like how clean and minimal it is - not cluttered at all. I see you're using an I suggest you solve this design challenge and make the UI easier to parse by formatting this data as a table, rather than a flex. One column should be the addresses, just like you have them. A separate column should take `isFileSystemAddress' and display one of two options:
If you go this route, I'll leave it up to you whether you want to keep the opacity behavior you already have. IMO something being greyed out suggests that it's broken or that I can't click it yet, so maybe the new second column of the table already handles that state. You might even sort to place all addresses with pages on top in one group followed by all addresses without pages. What about displaying other metadata on top? You have builders - what about checked-in builders? Or personal pages created? That's a personal preference, I just wanted to mention it. |
|
- Transformed the builders' UI from a flex view to a sleek table layout - Introduced two columns: `Addresses` and `Profile Links` - Added a dynamic count for `Builders pages created`
- The loading spinner is now centered in the table while loading.
Description:Implemented all the changes suggested by @derrekcoleman in the comments. If there’s anything else to tweak or add, just let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really nice 👌
Requesting a few typo fixes for polish and encouraging you to make a small tweak in the order of builders on the table.
- Changed "Buildes:" to "Builders:" - Changed "Buildes pages:" to "Builders pages:". - Changed "teh buildres" to "the buildres"
…6/batch8.buidlguidl.com into List-all-members-batch-8
- Divided builders into two arrays, buildersWithProfile and buildersWithoutProfile, based on the presence of a profile page. - Updated rendering logic to display builders with profile pages first, followed by those without profiles. - Adjusted key prop for tr elements to ensure unique keys and prevent conflicts.
Great job, @rohann06! Merged 🔥🔥🔥 |
Description
🚀 New Builders Route: Added a dedicated route to the navbar for quick and seamless access to all builders.
📄 Fresh Builders Page: Launched
page.tsx
to display the page header and proudly show the total number ofbuilders in the batch.
🔄 Dynamic Members List: Refined component structure with a new
_components
folder and craftedMembersList.tsx
to dynamically list all builder addresses.🔗 Smooth Navigation: Integrated
next/link
for effortless navigation to individual builder pages with a single click.🚫 Smart Links Handling: Disabled links and reduced opacity for builders without profile pages to avoid 404 errors
and maintain a smooth user experience.
🌟 Highlighted Active Profiles: Made addresses of builders with completed profiles stand out, allowing users to
easily find and recognize active contributors.
Your ENS/address: 0x4a9A95B6fe3b9416f0c78A8735Aa075c75AF46a4