Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added umutarray page #14

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Added umutarray page #14

merged 6 commits into from
Aug 29, 2024

Conversation

umutarray
Copy link
Contributor

Description

Here is my personal page

,
image

Additional Information

Your ENS/address: 0x3566ce434c0d8B80934354c806f8651e1cC91EDD

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch8-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 2:25pm

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @umutarray!

As a general advice, please ensure you create and check out a new branch (see contribution guideline, https://gist.github.com/ZakGriffith/69d1eb8baebddd7d370b87a65a7e3ec0), so that you adhere to the guidelines, which is important to contribute to open source projects.

Below, you'll find a few comments on minor code improvements.

@umutarray
Copy link
Contributor Author

@phipsae I editted my code. can you check it please ?

@derrekcoleman
Copy link
Member

Hey @umutarray! I love the simple color palette you're using here. My eyes can deal with the low contrast between pink and white, but others' may not be able to. Between you and me, it's gorgeous!

Please make sure you're using Prettier when saving so we all have consistent conventions (e.g. semicolons or no) and to fix the build errors we're seeing at the moment:

./app/builders/0x3566ce434c0d8B80934354c806f8651e1cC91EDD/page.tsx
5:7 Error: 'umutArray' is assigned a value but never used. @typescript-eslint/no-unused-vars
5:16 Warning: Delete · prettier/prettier

Even that first one about umutArray will go away after you use Prettier. I believe it's being triggered because of the space between umutArray : and the colon : in line five. Try it out and lmk if you have any questions.

I also recommend you add some padding between your social media buttons.

@umutarray
Copy link
Contributor Author

@derrekcoleman can you check it please :)

@phipsae phipsae removed their assignment Aug 26, 2024
@phipsae phipsae requested review from phipsae and derrekcoleman and removed request for phipsae August 26, 2024 15:12
@phipsae phipsae assigned phipsae and umutarray and unassigned phipsae Aug 26, 2024
Copy link
Member

@derrekcoleman derrekcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umutarray thanks for the fixes and the padding 👌

See my requested change for another Prettier error that's making CI fail.

@umutarray
Copy link
Contributor Author

Hi @derrekcoleman,
I made it fixed. Can you please look at ?

@derrekcoleman derrekcoleman merged commit 7f55744 into BuidlGuidl:main Aug 29, 2024
2 checks passed
@derrekcoleman
Copy link
Member

Thank you for your persistence with the build errors! Merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants