-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added umutarray page #14
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @umutarray!
As a general advice, please ensure you create and check out a new branch (see contribution guideline, https://gist.github.com/ZakGriffith/69d1eb8baebddd7d370b87a65a7e3ec0), so that you adhere to the guidelines, which is important to contribute to open source projects.
Below, you'll find a few comments on minor code improvements.
packages/nextjs/app/builders/0x3566ce434c0d8B80934354c806f8651e1cC91EDD/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3566ce434c0d8B80934354c806f8651e1cC91EDD/page.tsx
Outdated
Show resolved
Hide resolved
@phipsae I editted my code. can you check it please ? |
Hey @umutarray! I love the simple color palette you're using here. My eyes can deal with the low contrast between pink and white, but others' may not be able to. Between you and me, it's gorgeous! Please make sure you're using Prettier when saving so we all have consistent conventions (e.g. semicolons or no) and to fix the build errors we're seeing at the moment:
Even that first one about I also recommend you add some padding between your social media buttons. |
@derrekcoleman can you check it please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umutarray thanks for the fixes and the padding 👌
See my requested change for another Prettier error that's making CI fail.
packages/nextjs/app/builders/0x3566ce434c0d8B80934354c806f8651e1cC91EDD/page.tsx
Outdated
Show resolved
Hide resolved
Hi @derrekcoleman, |
Thank you for your persistence with the build errors! Merged 🚀 |
Description
Here is my personal page
,
Additional Information
Your ENS/address: 0x3566ce434c0d8B80934354c806f8651e1cC91EDD