-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add personal builder page #22
Conversation
@krvvs is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice page, and I appreciate that you're using some SE2 hooks like ENS. Thank you, @krvvs!
And a very well PR description!
I've added a few minor comments below.
packages/nextjs/app/builders/0xe9Ad7D1C2069E0Fa9b5852Adc77C9196651BB8b8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xe9Ad7D1C2069E0Fa9b5852Adc77C9196651BB8b8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xe9Ad7D1C2069E0Fa9b5852Adc77C9196651BB8b8/page.tsx
Outdated
Show resolved
Hide resolved
@phipsae Thanks for your prompt review. Resolved all comments you gave! |
packages/nextjs/app/builders/0xe9Ad7D1C2069E0Fa9b5852Adc77C9196651BB8b8/page.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you spotted the error, just make this small change, and then we'll merge.
Thank you for your effort and the great page!
packages/nextjs/app/builders/0xe9Ad7D1C2069E0Fa9b5852Adc77C9196651BB8b8/page.tsx
Outdated
Show resolved
Hide resolved
Thanks! Working great, I gonna merge it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Description
1. Added a builder page
Created a personal profile page under
packages/nextjs/app/builders
.The page displays:
2. Added remote image handling for GitHub avatars
Updated the
nextjs.config.js
file to allow the Next.js Image Optimization API to load images from GitHub avatars (https://avatars.githubusercontent.com).This change ensures that images from GitHub user profiles can be fetched and properly displayed in the application by specifying a remote pattern with the necessary protocol, hostname, and pathname.
Additional Information
Related Issues
Your ENS/address
0xe9Ad7D1C2069E0Fa9b5852Adc77C9196651BB8b8