added my builder profile #11
Conversation
|
@Superior212 is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@derrekcoleman @phipsae updated the PR, is this more descriptive? |
There was a problem hiding this comment.
Thank you very much for your personal page! It's simple, but looks great :)
Regarding the PR description please don't forget to relate to the respective issue (see https://gist.github.com/ZakGriffith/69d1eb8baebddd7d370b87a65a7e3ec0).
Please ensure that you don’t push changes to files unrelated to this PR. You can find my comments below.
packages/nextjs/app/builders/0x62CeF3Ca8b52a9C69a17236CA2c56Cdb7a383E8e/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x62CeF3Ca8b52a9C69a17236CA2c56Cdb7a383E8e/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x62CeF3Ca8b52a9C69a17236CA2c56Cdb7a383E8e/page.tsx
Outdated
Show resolved
Hide resolved
|
@derrekcoleman @phipsae fixed the issues Kindly assist me to check it out |
There was a problem hiding this comment.
@Superior212, it's looking great! I'm following up on @phipsae's request to keep your PR focused and clean: each pull request should only do one thing, so a few files that were (accidentally?) included in your commits should be removed before we merge.
The main goal of the batch is to practice your collaboration and "git-fu" 🥷, so let us know if you would like any guidance using git rebase, git push --force, and other ways of manipulating the git history.
|
@phipsae @derrekcoleman removed files |
There was a problem hiding this comment.
In the beginning it can be challenging at first to contribute to repos, that's why we are having this course :)
As @derrekcoleman mentioned, it's crucial to keep the codebase intact and only add or modify the files necessary for your PR to implement the specific feature.
Please review the comments below and ensure that no code is deleted from the main branch, as we need this parts.
Superior212
force-pushed
the
9-personal-page
branch
from
129c00c to
2123a16
Compare
|
@derrekcoleman @phipsae, please check it now, i have made the changes |
There was a problem hiding this comment.
@Superior212 only one little change, and then you have it!
See my comment below and make sure that the yarn.lock file is also correct.
package.json
Outdated
| @@ -37,10 +37,15 @@ | |||
| }, | |||
| "packageManager": "[email protected]", | |||
| "devDependencies": { | |||
| "@types/react": "^18.3.5", | |||
There was a problem hiding this comment.
These are not needed here, as they belong and are in the nextjs folder package.json.
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "react": "^18.3.1", | ||
| "react-icons": "^5.3.0" |
There was a problem hiding this comment.
These are not needed here, as they belong and are in the nextjs folder package.json.
|
@phipsae @derrekcoleman have removed the packages from the fille |
Superior212
force-pushed
the
9-personal-page
branch
from
2686b42 to
29ede1e
Compare
|
@phipsae can I also start working on other issues immediately after this is merged? |
|
@Superior212 can you please run once more yarn install and push? |
|
@phipsae done |
|
Finally we can merge!!! 🎉 Thank for your patience and page! :) |
|
Thank you, so i can proceed with other issues |
Description
packages/nextjs/app/builders/0x62CeF3Ca8b52a9C69a17236CA2c56Cdb7a383E8e/page.tsxAdditional Information
address:0x62CeF3Ca8b52a9C69a17236CA2c56Cdb7a383E8e