Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viem for detecting proxy contracts logic #82

Merged
merged 8 commits into from
Apr 13, 2024
Merged

Conversation

portdeveloper
Copy link
Member

Description

This PR:

  • Migrates the proxy detection logic that we currently use from evm-proxy-detection to viem
  • Adds the ability to detect Zora contracts by first checking for EIP-1967

There still might be some rough edges on this PR so feel free to give me some harsh feedback! It helps more that way!

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 10:09am

@portdeveloper portdeveloper marked this pull request as ready for review April 8, 2024 07:24
@portdeveloper portdeveloper requested review from Pabl0cks and technophile-04 and removed request for Pabl0cks April 8, 2024 07:24
Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's looking good to me!

GJ @portdeveloper!!

@technophile-04
Copy link
Member

Tysm @portdeveloper , for all the research and handling the EIP-1967 !! Really appreciate it !!

Just added a couple of comment

Also btw we should also remove the evm-proxy-detect library now 🙌

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really AWESOME JOB Port !! Tested and works nicely also thanks to Pablo too for testing !

Merging this 🙌

@technophile-04 technophile-04 merged commit 8cbd974 into main Apr 13, 2024
3 checks passed
@portdeveloper portdeveloper deleted the feat/proxies-viem branch April 25, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants