allow more networks for proxy contracts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
portdeveloper
approved these changes
Apr 7, 2024
|
Thanks Port, Merging this for now but lets get our custom solution once read 🙌! |
technophile-04
commented
Apr 25, 2024
Comment on lines
+82
to
+87
| const chain = extractChain({ | ||
| id: parseInt(network) as AllowedNetwork, | ||
| chains: Object.values(scaffoldConfig.targetNetworks), | ||
| }); | ||
| // @ts-expect-error this might be present or might not be | ||
| const alchmeyRPCURL = chain.rpcUrls?.alchemy?.http[0]; |
There was a problem hiding this comment.
marking this, for future use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently merged #80, it was a quick fix but maybe instead of relying on ethers for alchemy provider (which has very limited providers) we rely on general JsonRpcProvider and get the alchemy link from viem chains.
Also updated the logic a bit so now we only check for proxy contracts if we have viem's alchemy link for that chain