Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add uids to overloaded methods #73

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

portdeveloper
Copy link
Member

Description

This PR:

  • Adds uids only to the overloaded functions, keeping the others same as their name, thus enables the url to be shorter
  • Moves the augmentMethodsWithUid function out of the component to make things cleaner

as suggested by Shiv.

Thanks for the idea @technophile-04 !

Please be nitpicky and rude if you are reviewing this PR!

Before

chrome_LDBMA3tDFM.mp4

After

chrome_RliRwMqJsQ.mp4

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview Mar 14, 2024 6:19am

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niccceee TYSM Port, clean and works great !!!

@technophile-04 technophile-04 merged commit bbf8460 into main Mar 14, 2024
3 checks passed
@portdeveloper portdeveloper deleted the feat/better-uids branch March 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants