-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style issues in Contract detail page #57
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks great, thank you! Regarding mobile menu burger/close button, I meant they should be the same, changing bg on hover. But I forgot that no one sees hover on mobiles, so that hover effects doesn't matter 🤷♂️ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues as well @Pabl0cks ! Great work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great !!
Just an idea that came to my mind :
maybe in placeholder should we add "address or ENS"?
Just to be clear with new people they can directly use ENS too
We can just do :
const addressInputProps = { ...inputProps, placeholder: "address or ENS" };
return <AddressInput {...addressInputProps} />;
Here :
return <AddressInput {...inputProps} />; |
What do you all think?
Love that!! At some point I had the same thought, but forgot! I think BG crew would put ENS instinctively but external users can make use of that little help. Pushing that change 🙌 |
Tysm Pablo !! |
Description
Haven't fixed this one because I think it means changing
<Address>
component. Can add it ahover:opacity-70
effect, but maybe we should do it in SE-2 then.If you find any other style issue, lmk to fix! 🙌♥