Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style issues in Contract detail page #57

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Conversation

Pabl0cks
Copy link
Member

@Pabl0cks Pabl0cks commented Feb 7, 2024

Description

Copy button doesn't have hover effect (minor)

Haven't fixed this one because I think it means changing <Address> component. Can add it a hover:opacity-70 effect, but maybe we should do it in SE-2 then.

If you find any other style issue, lmk to fix! 🙌♥

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 11:20am

@rin-st
Copy link
Member

rin-st commented Feb 7, 2024

Looks great, thank you!

Regarding mobile menu burger/close button, I meant they should be the same, changing bg on hover. But I forgot that no one sees hover on mobiles, so that hover effects doesn't matter 🤷‍♂️ .

Copy link
Member

@portdeveloper portdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues as well @Pabl0cks ! Great work 👍

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great !!

Just an idea that came to my mind :

Screenshot 2024-02-08 at 3 22 51 PM

maybe in placeholder should we add "address or ENS"?

Just to be clear with new people they can directly use ENS too

We can just do :

const addressInputProps = { ...inputProps, placeholder: "address or ENS" };
return <AddressInput {...addressInputProps} />;

Here :

What do you all think?

@Pabl0cks
Copy link
Member Author

Pabl0cks commented Feb 8, 2024

maybe in placeholder should we add "address or ENS"?

Just to be clear with new people they can directly use ENS too

Love that!! At some point I had the same thought, but forgot! I think BG crew would put ENS instinctively but external users can make use of that little help.

Pushing that change 🙌

@technophile-04
Copy link
Member

Tysm Pablo !!

@technophile-04 technophile-04 merged commit 11f19ec into main Feb 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some styles issues
4 participants