Merge stores into one, fix chain being different in store #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/nextjs/components/NetworksDropdown/NetworksDropdown.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/components/NetworksDropdown/AddCustomChainModal.tsx
Outdated
Show resolved
Hide resolved
technophile-04
approved these changes
Dec 2, 2024
Pabl0cks
approved these changes
Dec 2, 2024
|
Ok I updated the actions test file inline with #163 API and now everything seems to be passing, merging this 🙌 Thanks @portdeveloper and @Pabl0cks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
-> Removes useTargetNetwork hook since we are already able to get the network from the store, and the chain that matters in abi.ninja is not the wallet's chain but the selected chain in the NetworksDropdown
-> Updates network in the store as soon as a network is selected in the NetworksDropdown menu
-> Merges abi ninja store into global store since it is cleaner that way.
Testing
I have tested it locally with the existing cypress tests and passes 5/5 on cypress tests
_Closes #158