Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heimdall backend url #136

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Update heimdall backend url #136

merged 1 commit into from
Jul 22, 2024

Conversation

portdeveloper
Copy link
Member

Description

Uses the new url structure and can use https://heimdall-api-v2.fly.dev/ as an env var.

The new url is already added as an env var to the project at vercel.
It is live at: https://abi-ninja-v2-ewpdbpx46-buidlguidldao.vercel.app/

Additional Information

Related Issues

_Closes #133

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 1:42pm

@portdeveloper portdeveloper requested a review from Pabl0cks July 18, 2024 13:45
Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ @portdeveloper!! Looking good to me, just a couple of points to check:

  • https://heimdall-api-v2.fly.dev/ was not working for me, had to delete last '/' character to leave it like: https://heimdall-api-v2.fly.dev
  • When we merge, we'll need to update NEXT_PUBLIC_HEIMDALL_URL value in Vercel, right? Or how does the update workflow look for this PR to be seamless to the user?

@portdeveloper
Copy link
Member Author

GJ @portdeveloper!! Looking good to me, just a couple of points to check:

  • https://heimdall-api-v2.fly.dev/ was not working for me, had to delete last '/' character to leave it like: https://heimdall-api-v2.fly.dev
  • When we merge, we'll need to update NEXT_PUBLIC_HEIMDALL_URL value in Vercel, right? Or how does the update workflow look for this PR to be seamless to the user?

Ah sorry I forgot to mention it! We already have the env var ready at vercel but it only affects this branch
image

So before we merge, we can just delete the old one and make this new env var available on all deployments.

I think this is the best way to handle this but I am open to ideas!

@technophile-04
Copy link
Member

Tested it out nicely and works great!! Thanks @portdeveloper! I think @carletex can update the env + merge this PR

So the steps could be:

  1. Update the NEXT_PUBLIC_HEIMDALL_URL env for abi.ninja on vercel with :

    https://heimdall-api-v2.fly.dev
  2. Merge this branch, and it should trigger autodeploy on vercel along with this changes + the env set in vercel.

@carletex carletex merged commit 9b8a61e into main Jul 22, 2024
3 checks passed
@carletex
Copy link
Collaborator

Done!

@portdeveloper portdeveloper deleted the feat/upgrade-gulltoppr branch August 12, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants