Saving only failed tests

[KerH]

Adding the option to save only failures by running:

py.test --failure2file=FILENAME

OR save both:

py.test -p pytest_session2file --session2file=FILENAME --failure2file=FILENAME

[BuhtigithuB]

Hi @KerH ,

I will review the full extent of your PR ASAP, but at first glance it does not seems right to have 2 ways to pass "FILENAME", your --failure2file shall be bool type like --failure=only no??

[KerH]

Hi @BuhtigithuB, thank you for the review, it sounds right - changed it to save failures using a boolean flag instead (only one path should be provided in a single run). Let me know if you have any questions.

[BuhtigithuB]

Hi @KerH,

Can you squash your PR branch, it will help final code review as currently I can only see the mods you made over your initial PR.

Thanks

[KerH]

@BuhtigithuB please let me know if you have any questions or comments. Thank you

[BuhtigithuB]

Hi Harel, I am not so sure why you have a merge commit at the root of your PR branch... Also there 2 commits including earlier mods that you did in your earlier implementation for this feature they are not required. I don't want to carry these commits into the history of change as it gonna get confusing... You can do a rebase -i mark those commits as squash so they are going to be merge into a single commit including only your last implementation details, that way it gonna be easier to analyse you PR and merge it on my side. Also if you merge on your side it will create a mess for you over time... So I suggest you squash (rebase -i pick the commits to be squash - merged as a single commit) then create a new branch from master cherry pick that single commit and paste it on that new branch and open a new PR for that branch... That way your repo gonna be clean and the history of the main repo too. Thanks for your help

…

On Fri, Feb 10, 2023 at 3:53 AM Harel.K ***@***.***> wrote: @BuhtigithuB <https://github.com/BuhtigithuB> please let me know if you have any questions or comments. Thank you — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMVNR2IELMESQEEFXWMIYTWWX6X5ANCNFSM6AAAAAASMGPHLE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[KerH]

Hi @BuhtigithuB, I'm Closing this one as I created a new one here.