LaTeX text formatter fixes #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "close" button is no longer needed. Previously, after the user clicked Confirm, there was no way to change what tiers were used, so we provided a Close button that would let them start over from a new page load. Now if the user decides to change what buttons are selected and clicks Confirm again, the result will change accordingly. It would still be nice to be able to collapse the format window, but we shouldn't do that via a page refresh.
Change the button text, and refactor file names and class names.
to differentiate it visually from all the input tier names / radio buttons below it
|
|
|
I think this all looks great! Doing the refactoring for the TranslatableText definitely makes sense. |
sciepsilon
commented
Jun 27, 2021
sciepsilon
commented
Jun 27, 2021
sciepsilon
commented
Jun 27, 2021
| } | ||
|
|
||
| .formatResultSection { | ||
| background : rgb(215, 233, 252); | ||
| .latexResultContainer { | ||
| overflow-x: scroll; |
There was a problem hiding this comment.
Replace scroll -> auto. That way, the scroll bar only shows up when it's needed. (Too late to make this change now that we've already merged, but I'll keep it in mind for future PRs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to the text format feature (PR #84, issue #81).
<TranslatableText>for all user-facing text<TranslatableText>a lot easier)