Report AGS summary information within additional metadata #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses data from the AGS summary to populate as many fields as possible in the additional_metadata when BGS data are not available. The summary attribute from AGS validation is no longer returned as a standalone item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request updates the API so that the information returned by the AGS validator within the
summaryitem is now returned as part of the additional metadata. The AGS summary is no longer explicitly returned. Where both BGS and AGS additional_metadata are available, the BGS values are used as they contain more data.The work resolves the comment here: #142 (comment)
To test
example_ags.agswith the AGS validator and confirm additional metadata are returned (and no summary)example_ags.agswith the BGS validator and confirm additional metadata are returned, includingbgs_projectsfieldexample_ags.agswith the both validators and confirm additional metadata are returned, includingbgs_projectsfield